Hi All,
I’ve managed to get the weather module in my configuration up and working again thanks to some information published here in the forums by Mark Olson (n2hifi) and via PM with Paul Jameson (pjjameso) and Alejandro.
However, I am running into a small issue. In my weather module, I have given the user the ability to view the night forecast as well as the default day forecast for a 5 day period. The issue arises when it is currently night time and I ask it to display the night forecast. It errors out with the error ‘weatherData.dayf.day[i].part[0].icon’ has no properties… which I totally expect because at night time there is no section in the XML stream that has the day time info for Day 0 (i.e., today) anymore. See data feeds below.
Day Time Data Feed
<dayf>
<lsup>11/25/13 8:56 AM EST</lsup>
<daydt="Nov 25" t="Monday" d="0">
<hi>1</hi>
<low>-1</low>
<sunr>7:17 AM</sunr>
<suns>4:25 PM</suns>
<partp="d">
<icon>14</icon>
<t>Few Snow Showers</t>
<wind>
<s>13</s>
<gust>N/A</gust>
<d>181</d>
<t>S</t>
</wind>
<bt>Snow Showers</bt>
<ppcp>50</ppcp>
<hmid>80</hmid>
</part>
<partp="n">
<icon>16</icon>
<t>Snow</t>
<wind>
<s>21</s>
<gust>N/A</gust>
<d>70</d>
<t>ENE</t>
</wind>
<bt>Snow</bt>
<ppcp>100</ppcp>
<hmid>89</hmid>
</part>
</day>
Night Time Data Feed
<dayf>
<lsup>11/25/13 6:08 PM EST</lsup>
<daydt="Nov 25" t="Monday" d="0">
<hi>N/A</hi>
<low>-3</low>
<sunr>7:16 AM</sunr>
<suns>4:25 PM</suns>
<partp="n">
<icon>14</icon>
<t>Snow Shower</t>
<wind>
<s>21</s>
<gust>N/A</gust>
<d>207</d>
<t>SSW</t>
</wind>
<bt>Snow Showers</bt>
<ppcp>60</ppcp>
<hmid>68</hmid>
</part>
</day>
I am attempting to fix this issue (which I did not have with the previous XML feed from 'xml.weather.com') by using the code below:
// If it is the current day and we are asking to look at the evening data... typically the second
// set of data for the day's forecast, but at night time there is no data in that section because
// it is already the evening and that section simply does not exist. So we ask to simply use the
// first section of forecasted as it already contains the night time data.
if (i == 0 && timeOfDay == 1 && weatherData.hasOwnProperty('dayf.day[0].part[1].icon'))
{
var icon = "" + weatherData.dayf.day[0].part[0].icon; // Force it to be a string
var weatherText = "" + weatherData.dayf.day[0].part[0].t;
var pop = weatherData.dayf.day[0].part[0].ppcp;
}
else
{
// Otherwise, use the data in the first or second parts (dictated by the timeOfDay variable) of
// the XML stream as both the day and night time data is available.
var icon = "" + weatherData.dayf.day[i].part[timeOfDay].icon; // Force it to be a string
var weatherText = "" + weatherData.dayf.day[i].part[timeOfDay].t;
var pop = weatherData.dayf.day[i].part[timeOfDay].ppcp;
}
Note ‘timeOfDay’ variable is either a 0 (day) or 1 (night) as set by the code in my ‘Day/Night’ icon on the weather page. By default it is set to 0.
However, it does not work. I still get the same error. Seems I can only get the ‘hasOwnProperty’ method to work on the top level of objects and not in a subsection. I’ve tried various permutations but to no avail.
weatherData.hasOwnProperty(‘part[1]’)
weatherData.hasOwnProperty(‘part[1].icon’)
weatherData.dayf.day[0].part[1].hasOwnProperty(‘icon’)
weatherData.dayf.day[0].hasOwnProperty(‘part[1]’)
I've also tried to play around with the following thinking this might help, but no go.
if ('y' in x) {
// ......
}
Can anyone shed some light on this for me? If anyone has an alternate/more elegant solution, please chime in. I will be submitting the new version to remote central as soon as this issue is resolved. I know a number of individuals have emailed me about this weather module and are eager for a resolution.
Thanks in advance,
Scott
